feat: Extract Foreign Key from Payload #60
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to clean up some ways that the package handles things.
There would be a constraint violation when trying to approve the Model if it had a foreign key, i.e. a Comment model would normally have a relationship to a User model. Now, as long as the user adds the foreign key, everything should be okay, e.g.
If you were to add a comment via a relationship, e.g.
there will be no difference, as this will always send the foreign key along with it.
user_id
) then that property would be added to thenew_data
JSON payload, and I just didn't like how that looked, so I have extracted it to its own column in theapprovals
table. This does mean the user needs to run a new migration though when using the next version (should be v1.5.0)